planner: fix wrong row compare logic in expression_rewriter #8241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
reviewed
Nov 8, 2018
planner/core/expression_rewriter.go
Outdated
| @@ -220,6 +220,24 @@ func (er *expressionRewriter) constructBinaryOpFunction(l expression.Expression, | |||
| if err != nil { | |||
| return nil, errors.Trace(err) | |||
| } | |||
| if evalexpr, ok := expr1.(*expression.Constant); ok { | |||
| _, isNull, err1 := evalexpr.EvalInt(er.ctx, chunk.Row{}) | |||
| if err1 != nil { | |||
There was a problem hiding this comment.
if err1 != nil || isNil {
return expr1, err1
}
We do not need the errors.Trace now.
| @@ -220,6 +220,24 @@ func (er *expressionRewriter) constructBinaryOpFunction(l expression.Expression, | |||
| if err != nil { | |||
| return nil, errors.Trace(err) | |||
| } | |||
| if evalexpr, ok := expr1.(*expression.Constant); ok { | |||
| _, isNull, err1 := evalexpr.EvalInt(er.ctx, chunk.Row{}) | |||
|
@XuHuaiyu addressed |
|
/run-all-tests |
|
PTAL @zz-jason |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When execute this SQL:
SELECT (1,2,3) < (1,NULL, 3).TiDB:
MySQL:
Correct compare logic is comparing prefix of row until there is different digit between them.
If they has same prefix before
NULLdigit, it will returnNULL.What is changed and how it works?
adding check code before entering next recursion.
Check List
Tests
Side effects
Related changes