util/chunk: preallocate the columns array in MutRow to avoid array resize #8348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When checking the flamegraph of Lightning (which does lots of INSERTs) on a table with 37 columns, I found that
MutRowFromDatums
spends a noticeable amount of time inruntime.growslice
. This means the capacity ofc.columns
isn't large enough andappend()
will need to reallocate and move the content (as of Go 1.11 the capacity grows like 0 → 2 → 4 → 8 → 16 → …).What is changed and how it works?
Since the final length is known, we just preallocate the slice with the known capacity.
Check List
Tests
runtime.growslice
no longer appears directly insideMutRowFromDatums
in thepprof
CPU profile.Code changes
Side effects
Related changes
This change is