Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: preparation for Go1.11 module cherry pick #8388

Merged
merged 8 commits into from Nov 22, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Nov 21, 2018

What problem does this PR solve?

Preparation for cherry pick Go1.11 module to release-2.1 branch

What is changed and how it works?

Cherry pick the later three PRs is quite easy, nearly no conflict.

commit 3727e15f259ddf4f3d3c5945ec3a7b4a4c55abde (HEAD -> cherry-module, tiancaiamao/cherry-module)
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Wed Nov 21 21:07:26 2018 +0800

    *: move parser to a separate repository

commit b06a5d4a71f8385584189dfd2661fa2130b9a362
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Wed Oct 24 13:19:10 2018 +0800

    *: make parser package dependency as small as possible (#7989)

commit 24c04191addc5665d989a872f8483371bf3e58b6
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Sun Oct 21 13:21:26 2018 +0800

    *: move `Statement` and `RecordSet` from ast to sqlexec package (#7970)

commit 240db91627ac5ee086e5a85a98843a683c698349
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Fri Oct 19 19:37:55 2018 +0800

    *: move ast.NewValueExpr to standalone parser_driver package (#7952)
    
    Make the ast package get rid of the dependency of types.Datum

This one is quite difficult, I rewrite the changes from the original PR #8036

    *: move parser to a separate repository

To make CI pass, release-2.1 need a special parser branch which I'll push later.

Still WIP, there are two test cases fail.


This change is Reviewable

@tiancaiamao tiancaiamao added priority/release-blocker This PR blocks a release. Please review it ASAP. and removed status/WIP labels Nov 22, 2018
@zz-jason
Copy link
Member

@tiancaiamao CI failed.

@XuHuaiyu XuHuaiyu changed the title *: Cherry-pick Go1.11 module to the release-2.1 branch *: cherry-pick Go1.11 module to the release-2.1 branch Nov 22, 2018
@tiancaiamao
Copy link
Contributor Author

Some important notes:

#8398 is reverted in this PR, you can add it back again after my work finish @jackysp

In this commit https://github.com/pingcap/tidb/pull/7862/files#diff-c31b8654bc3f8f52137403cf3dc617faL571
GetTableColumnID is removed from the latest parser, so I add a GetTableColumnID in the util/admin package @crazycs520

#7842 is not in the release-2.1 branch, so the parser used by release-2.1 reset the changes @eurekaka

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1

@tiancaiamao
Copy link
Contributor Author

PTAL @zz-jason @jackysp

@tiancaiamao tiancaiamao changed the title *: cherry-pick Go1.11 module to the release-2.1 branch *: preparation for cherry pick Go1.11 module to release-2.1 branch Nov 22, 2018
@tiancaiamao tiancaiamao changed the title *: preparation for cherry pick Go1.11 module to release-2.1 branch *: preparation for Go1.11 module cherry pick Nov 22, 2018
@zz-jason
Copy link
Member

LGTM

@jackysp
Copy link
Member

jackysp commented Nov 22, 2018

Great work! @tiancaiamao
I'll approve the pr when all the tests passed.

@tiancaiamao
Copy link
Contributor Author

/run-common-test tidb-test=pr/657

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/run-common-test tidb-test=pr/657

@tiancaiamao
Copy link
Contributor Author

/run-integration-ddl-test tidb-test=pr/657

@tiancaiamao
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/657

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit fc4c93f into pingcap:release-2.1 Nov 22, 2018
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 22, 2018
@tiancaiamao tiancaiamao deleted the cherry-module branch November 23, 2018 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants