*: Txn() function signature refactor and remove ActivePendingTxn() (#8327) #8567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingcap#8327) * change Txn() function signature to Txn(active bool) * ActivePendingTxn() is not used any more because Txn() does the work * change executor builder getStartTS() uint64 to getStartTS() (uint64, error)
|
/run-all-tests tidb-test=pr/674 |
crazycs520
reviewed
Dec 4, 2018
| @@ -125,7 +125,7 @@ func (e *CheckIndexRangeExec) Open(ctx context.Context) error { | |||
|
|
|||
| func (e *CheckIndexRangeExec) buildDAGPB() (*tipb.DAGRequest, error) { | |||
| dagReq := &tipb.DAGRequest{} | |||
| dagReq.StartTs = e.ctx.Txn().StartTS() | |||
| dagReq.StartTs = e.ctx.Txn(true).StartTS() | |||
There was a problem hiding this comment.
should check if sctx.Txn(true).Valid() first?
tiancaiamao
added
the
Priority/P1
winkyao
reviewed
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry pick from #8327
What is changed and how it works?
I thought #8327 is just a simple refactor, so I did not cherry pick that to release 2.1
But later it turns out that without the commit, release 2.1 will fail on this test #8566
@crazycs520 @winkyao
This change is