Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: support system variable interactive_timeout (#8487) #8573

Merged
merged 12 commits into from Dec 14, 2018

Conversation

@hhxcc
Copy link
Contributor

commented Dec 4, 2018

What problem does this PR solve?

support system variable interactive_timeout. #8487

What is changed and how it works?

when client set Capability Flags CLIENT_INTERACTIVE, init wait_timeout with interactive_timeout

Check List

Tests

  • Integration test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to be included in the release note

This change is Reviewable

@sre-bot

This comment has been minimized.

Copy link

commented Dec 4, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@hhxcc

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2018

@lysu Could you help to write a integration test , please ?

@zz-jason zz-jason changed the title [WIP]support system variable interactive_timeout (#8487) [WIP]session: support system variable interactive_timeout (#8487) Dec 5, 2018

@lysu lysu self-assigned this Dec 7, 2018

lysu added some commits Dec 7, 2018

@lysu

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

/run-all-tests tidb-test=pr/679

@lysu

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

/run-common-test tidb-test=pr/679

@pingcap pingcap deleted a comment from jackysp Dec 11, 2018

lysu added some commits Dec 11, 2018

@lysu lysu changed the title [WIP]session: support system variable interactive_timeout (#8487) session: support system variable interactive_timeout (#8487) Dec 11, 2018

@lysu
Copy link
Member

left a comment

LGTM

@lysu lysu added the status/LGT1 label Dec 11, 2018

@lysu lysu requested review from jackysp and tiancaiamao Dec 11, 2018

@lysu

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

/run-all-tests tidb-test=pr/679

@lysu

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

/run-common-test tidb-test=pr/679
/run-integration-common-test tidb-test=pr/679

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

/run-common-test tidb-test=pr/679

@lysu

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

/run-all-tests tidb-test=pr/679

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

LGTM

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

/run-common-test tidb-test=pr/679
/run-integration-common-test tidb-test=pr/679

@jackysp
Copy link
Member

left a comment

LGTM

@jackysp jackysp added status/LGT2 and removed status/LGT1 labels Dec 13, 2018

ngaut and others added some commits Dec 13, 2018

@lysu lysu merged commit 808eab1 into pingcap:master Dec 14, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.