Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: Add endKey support for RawScan #8602

Merged
merged 8 commits into from Dec 21, 2018

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Dec 6, 2018

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

What problem does this PR solve?

This PR added endKey support for RawScan, so we can specify the ending of the range we want to scan.

What is changed and how it works?

A new field endKey was added to RawScanRequest.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • kvproto is upgraded in this PR. If run this TiDB with older version of TiKV that doesn't handles the endKey parameter, the endKey will be ignored.

Related changes

  • None

This change is Reviewable

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Copy link
Contributor Author

@zhangjinpeng1987 @tiancaiamao PTAL

@tiancaiamao
Copy link
Contributor

LGTM

kvproto is updated in this PR, so you should write the compatibility issues in the description @MyonKeminta

Side effects
None

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 12, 2018
@MyonKeminta
Copy link
Contributor Author

@zhangjinpeng1987 @disksing PTAL

disksing
disksing previously approved these changes Dec 21, 2018
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Copy link
Contributor Author

/run-all-tests

@MyonKeminta
Copy link
Contributor Author

/run-unit-test

@MyonKeminta MyonKeminta added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2018
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MyonKeminta MyonKeminta merged commit 20a468d into pingcap:master Dec 21, 2018
@MyonKeminta MyonKeminta deleted the misono/raw-scan-end-key branch December 21, 2018 11:31
kamijin-fanta added a commit to kamijin-fanta/tidb that referenced this pull request Dec 26, 2018
- ref: pingcap#8602

Signed-off-by: kamijin_fanta <kamijin@live.jp>
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants