Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binlog socket config for compatible with kafka version pump #8747

Merged
merged 5 commits into from Dec 19, 2018

Conversation

Projects
None yet
5 participants
@WangXiangUSTC
Copy link
Member

WangXiangUSTC commented Dec 19, 2018

What problem does this PR solve?

add binlog socket config for compatible with kafka version pump
already merge to master, cherry pick to release 2.1
pr: #8732

What is changed and how it works?

git cherry-pick
and then resolve some conflict

Check List

Tests

  • Integration test

Related changes

  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

This change is Reviewable

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@GregoryIan
Copy link
Contributor

GregoryIan left a comment

LGTM

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Dec 19, 2018

/rebuild

@zimulala
Copy link
Member

zimulala left a comment

Could you add a test to config_test.go?

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Dec 19, 2018

/run-all-tests

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Dec 19, 2018

/rebuild

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Dec 19, 2018

add test done @zimulala

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Dec 19, 2018

/run-all-tests

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Dec 19, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala zimulala merged commit 79180dc into pingcap:release-2.1 Dec 19, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@WangXiangUSTC WangXiangUSTC deleted the WangXiangUSTC:xiang/cherry-pick branch Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.