Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove `fail` field from TxnState (#8712) #8764

Merged
merged 6 commits into from Dec 25, 2018

Conversation

Projects
None yet
5 participants
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Dec 21, 2018

cherry pick from #8712

Please review session.go carefully.

@lysu @winkyao @jackysp


This change is Reviewable

*: remove `fail` field from TxnState (#8712)
Originally, fail is added to simplify error handling, avoiding large changes on
the Txn() interface API. But it turns out that fail introduces complexity.
So this commit removes the fail and makes an API refactoring.
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

/run-all-tests tidb-test=pr/708

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

/run-all-tests tidb-test=pr/708

1 similar comment
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

/run-all-tests tidb-test=pr/708

@tiancaiamao tiancaiamao force-pushed the tiancaiamao:cherry-2.0 branch from 6e6ef27 to 3b44646 Dec 21, 2018

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

/run-all-tests tidb-test=pr/708

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

/rebuild

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

/run-all-tests tidb-test=pr/708

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Dec 21, 2018

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@lysu

lysu approved these changes Dec 25, 2018

Copy link
Member

lysu left a comment

LGTM

@lysu lysu added require-LGT3 and removed status/LGT1 labels Dec 25, 2018

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Dec 25, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Dec 25, 2018

/run-integration-ddl-test tidb-test=pr/708 tikv=release-2.0 pd=release-2.0

@jackysp jackysp merged commit 305a083 into pingcap:release-2.0 Dec 25, 2018

11 of 12 checks passed

idc-jenkins-ci-tidb/integration-ddl-test Jenkins job is running.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:cherry-2.0 branch Dec 25, 2018

tiancaiamao added a commit that referenced this pull request Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.