Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: introduce plugin framework #8788

Merged
merged 9 commits into from Jan 14, 2019
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/pluginpkg/pluginpkg.go
Expand Up @@ -23,6 +23,7 @@ import (
"os/exec"
"path"
"path/filepath"
"strings"
"text/template"
"time"

Expand Down Expand Up @@ -98,6 +99,10 @@ func main() {
manifest["buildTime"] = time.Now().String()

pluginName := manifest["name"].(string)
if strings.Contains(pluginName, "-") {
log.Printf("plugin name should not contain '-'\n")
os.Exit(1)
}
if pluginName != filepath.Base(pkgDir) {
log.Printf("plugin package must be same with plugin name in manifest file\n")
os.Exit(1)
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Expand Up @@ -86,3 +86,5 @@ require (
sourcegraph.com/sourcegraph/appdash v0.0.0-20180531100431-4c381bd170b4
sourcegraph.com/sourcegraph/appdash-data v0.0.0-20151005221446-73f23eafcf67
)

replace github.com/pingcap/parser => github.com/lysu/parser v0.0.0-20190113135412-15ea37f53357
2 changes: 2 additions & 0 deletions go.sum
Expand Up @@ -81,6 +81,8 @@ github.com/klauspost/cpuid v0.0.0-20170728055534-ae7887de9fa5 h1:2U0HzY8BJ8hVwDK
github.com/klauspost/cpuid v0.0.0-20170728055534-ae7887de9fa5/go.mod h1:Pj4uuM528wm8OyEC2QMXAi2YiTZ96dNQPGgoMS4s3ek=
github.com/konsorten/go-windows-terminal-sequences v1.0.1 h1:mweAR1A6xJ3oS2pRaGiHgQ4OO8tzTaLawm8vnODuwDk=
github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
github.com/lysu/parser v0.0.0-20190113135412-15ea37f53357 h1:lryyLiB8f8SlRkG30lrPLJM0uITNL0NAaNZkOtmiC2A=
github.com/lysu/parser v0.0.0-20190113135412-15ea37f53357/go.mod h1:CJk6LPzPxAcwHIcTugQaKxzvTR10NDJ5ln8XR7uYTJk=
github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU=
github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
github.com/montanaflynn/stats v0.0.0-20180911141734-db72e6cae808 h1:pmpDGKLw4n82EtrNiLqB+xSz/JQwFOaZuMALYUHwX5s=
Expand Down
49 changes: 49 additions & 0 deletions plugin/conn_ip_example/conn_ip_example.go
@@ -0,0 +1,49 @@
// Copyright 2019 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package main

import (
"context"
"fmt"

"github.com/pingcap/tidb/plugin"
"github.com/pingcap/tidb/sessionctx/variable"
)

// Validate implements TiDB plugin's Validate SPI.
func Validate(ctx context.Context, m *plugin.Manifest) error {
fmt.Println("conn_ip_example validate called")
return nil
}

// OnInit implements TiDB plugin's OnInit SPI.
func OnInit(ctx context.Context, manifest *plugin.Manifest) error {
fmt.Println("conn_ip_example init called")
fmt.Println("read cfg in init", manifest.SysVars["conn_ip_example_test_variable"].Value)
return nil
}

// OnShutdown implements TiDB plugin's OnShutdown SPI.
func OnShutdown(ctx context.Context, manifest *plugin.Manifest) error {
fmt.Println("conn_ip_examples hutdown called")
return nil
}

// NotifyEvent implements TiDB Audit plugin's NotifyEvent SPI.
func NotifyEvent(ctx context.Context) error {
fmt.Println("conn_ip_example notifiy called")
fmt.Println("variable test: ", variable.GetSysVar("conn_ip_example_test_variable").Value)
fmt.Printf("new connection by %s\n", ctx.Value("ip"))
return nil
}
61 changes: 61 additions & 0 deletions plugin/conn_ip_example/conn_ip_example_test.go
@@ -0,0 +1,61 @@
// Copyright 2019 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package main_test

import (
"context"
lysu marked this conversation as resolved.
Show resolved Hide resolved

"github.com/pingcap/tidb/plugin"
"github.com/pingcap/tidb/sessionctx/variable"
)

func Example_LoadRunShutdownPlugin() {
ctx := context.Background()
var pluginVarNames []string
cfg := plugin.Config{
Plugins: []string{"conn_ip_example-1"},
PluginDir: "/home/robi/Code/go/src/github.com/pingcap/tidb/plugin/conn_ip_example",
GlobalSysVar: &variable.SysVars,
PluginVarNames: &pluginVarNames,
}

err := plugin.Init(ctx, cfg)
if err != nil {
panic(err)
}

ps := plugin.GetByKind(plugin.Audit)
for _, auditPlugin := range ps {
if auditPlugin.State != plugin.Ready {
continue
}
plugin.DeclareAuditManifest(auditPlugin.Manifest).NotifyEvent(context.Background(), nil)
}

err = plugin.Reload(ctx, cfg, plugin.ID("conn_ip_example-2"))
if err != nil {
panic(err)
}

for _, auditPlugin := range plugin.GetByKind(plugin.Audit) {
if auditPlugin.State != plugin.Ready {
continue
}
plugin.DeclareAuditManifest(auditPlugin.Manifest).NotifyEvent(
context.WithValue(context.Background(), "ip", "1.1.1.2"), nil,
)
}

plugin.Shutdown(context.Background())
}
15 changes: 15 additions & 0 deletions plugin/conn_ip_example/manifest.toml
@@ -0,0 +1,15 @@
name = "conn_ip_example"
kind = "Audit"
description = "just a test"
version = "1"
license = ""
sysVars = [
{name="conn_ip_example_test_variable", scope="Global", value="2"},
{name="conn_ip_example_test_variable2", scope="Session", value="2"},
]
validate = "Validate"
onInit = "OnInit"
onShutdown = "OnShutdown"
export = [
{extPoint="NotifyEvent", impl="NotifyEvent"}
]
70 changes: 70 additions & 0 deletions plugin/const.go
@@ -0,0 +1,70 @@
// Copyright 2019 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package plugin

// Kind presents the kind of plugin.
type Kind uint8

const (
// Audit indicates it is a Audit plugin.
Audit Kind = 1 + iota
// Authentication indicate it is a Authentication plugin.
Authentication
// Schema indicate a plugin that can change TiDB schema.
Schema
// Daemon indicate a plugin that can run as daemon task.
Daemon
)

func (k Kind) String() (str string) {
switch k {
case Audit:
str = "Audit"
case Authentication:
str = "Authentication"
case Schema:
str = "Schema"
case Daemon:
str = "Daemon"
}
return
}

// State present the state of plugin.
type State uint8

const (
// Uninitialized indicates plugin is uninitialized.
Uninitialized State = iota
// Ready indicates plugin is ready to work.
Ready
// Dying indicates plugin will be close soon.
Dying
// Disable indicate plugin is disabled.
Disable
)

func (s State) String() (str string) {
switch s {
case Uninitialized:
str = "Uninitialized"
case Ready:
str = "Ready"
case Dying:
str = "Dying"
case Disable:
str = "Disable"
}
return
}
50 changes: 50 additions & 0 deletions plugin/errors.go
@@ -0,0 +1,50 @@
// Copyright 2019 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package plugin

import (
"github.com/pingcap/parser/mysql"
"github.com/pingcap/parser/terror"
)

var (
errInvalidPluginID = createPluginError(mysql.ErrInvalidPluginID)
errInvalidPluginManifest = createPluginError(mysql.ErrInvalidPluginManifest)
errInvalidPluginName = createPluginError(mysql.ErrInvalidPluginName)
errInvalidPluginVersion = createPluginError(mysql.ErrInvalidPluginVersion)
errDuplicatePlugin = createPluginError(mysql.ErrDuplicatePlugin)
errInvalidPluginSysVarName = createPluginError(mysql.ErrInvalidPluginSysVarName)
errRequireVersionCheckFail = createPluginError(mysql.ErrRequireVersionCheckFail)
errUnsupportedReloadPlugin = createPluginError(mysql.ErrUnsupportedReloadPlugin)
errUnsupportedReloadPluginVar = createPluginError(mysql.ErrUnsupportedReloadPluginVar)
)

func createPluginError(code terror.ErrCode) *terror.Error {
return terror.ClassPlugin.New(code, mysql.MySQLErrName[uint16(code)])
}

func init() {
pluginMySQLErrCodes := map[terror.ErrCode]uint16{
mysql.ErrInvalidPluginID: mysql.ErrInvalidPluginID,
mysql.ErrInvalidPluginManifest: mysql.ErrInvalidPluginManifest,
mysql.ErrInvalidPluginName: mysql.ErrInvalidPluginName,
mysql.ErrInvalidPluginVersion: mysql.ErrInvalidPluginVersion,
mysql.ErrDuplicatePlugin: mysql.ErrDuplicatePlugin,
mysql.ErrInvalidPluginSysVarName: mysql.ErrInvalidPluginSysVarName,
mysql.ErrRequireVersionCheckFail: mysql.ErrRequireVersionCheckFail,
mysql.ErrUnsupportedReloadPlugin: mysql.ErrUnsupportedReloadPlugin,
mysql.ErrUnsupportedReloadPluginVar: mysql.ErrUnsupportedReloadPluginVar,
}
terror.ErrClassToMySQLCodes[terror.ClassPlugin] = pluginMySQLErrCodes
}
54 changes: 54 additions & 0 deletions plugin/helper.go
@@ -0,0 +1,54 @@
// Copyright 2019 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package plugin

import (
"strings"
"unsafe"
)

// DeclareAuditManifest declares manifest as AuditManifest.
func DeclareAuditManifest(m *Manifest) *AuditManifest {
return (*AuditManifest)(unsafe.Pointer(m))
}

// DeclareAuthenticationManifest declares manifest as AuthenticationManifest.
func DeclareAuthenticationManifest(m *Manifest) *AuthenticationManifest {
return (*AuthenticationManifest)(unsafe.Pointer(m))
}

// DeclareSchemaManifest declares manifest as SchemaManifest.
func DeclareSchemaManifest(m *Manifest) *SchemaManifest {
return (*SchemaManifest)(unsafe.Pointer(m))
}

// DeclareDaemonManifest declares manifest as DaemonManifest.
func DeclareDaemonManifest(m *Manifest) *DaemonManifest {
return (*DaemonManifest)(unsafe.Pointer(m))
}

// ID present plugin identity.
type ID string

// Decode decodes a plugin id into name, version parts.
func (n ID) Decode() (name string, version string, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Plugin name should not contain '-'

Copy link
Collaborator Author

@lysu lysu Jan 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decode has check a42f8e9#diff-51012a4c21599aa07955e2f374958792R40, refine msg in new commit, and pluginpkg also add a check 5bbc246

splits := strings.Split(string(n), "-")
if len(splits) != 2 {
err = errInvalidPluginID.GenWithStackByArgs(string(n))
return
}
name = splits[0]
version = splits[1]
return
}