binlog: use pumps client to write binlog (#7659) (#8078) #8822
Conversation
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/run-integration-compatibility-test |
|
/run-integration-compatibility-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/run-integration-ddl-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/run-integration-compatibility-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 tidb=release-2.0 |
| "google.golang.org/grpc" | ||
| ) | ||
|
|
||
| func init() { | ||
| grpc.EnableTracing = false | ||
| // don't need output pumps client's log | ||
| pumpcli.Logger.Out = ioutil.Discard |
There was a problem hiding this comment.
at the first, zhou sir don't want pump client print any log, it may disturb tidb's log. so I add this code.
we can refine pump client's log later, and remove this line if any other reviewer agree.
There was a problem hiding this comment.
hard to debug, create an issue for it
There was a problem hiding this comment.
OK，I will create a issue
|
LGTM |
|
@WangXiangUSTC ddl-test failed by the changes of https://github.com/pingcap/tidb-test/pull/708, it doesn't matter, just merge it, I'll move the ddl_test to tidb repo. |
|
@winkyao ok, thanks. |
|
Rebase releaes-2.0 master ? |
|
@tiancaiamao this version need guarantee the stability, rebase release-2.0 seems not a good thing |
|
Oh, I see. @WangXiangUSTC |
|
Please add the origin PR link in the PR description. |
|
@jackysp link added |
WangXiangUSTC
added
status/LGT2
What problem does this PR solve?
support new binlog in v2.0.10
What is changed and how it works?
git cherry-pick
pr:
#7659
#8078
Check List
Tests
This change is