planner, executor: add post-process after physical plan optimization and move buildProjBelowAgg from executor to planner #8828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
XuHuaiyu
reviewed
Dec 26, 2018
XuHuaiyu
added
type/enhancement
sig/execution
|
/run-all-tests |
qw4990
changed the title
zz-jason
reviewed
Dec 26, 2018
XuHuaiyu
changed the title
qw4990
force-pushed
the
phy_post_proc
branch
from
2635771
to
2b51b39
Compare
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Dec 28, 2018
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
winoros
reviewed
Dec 28, 2018
qw4990
force-pushed
the
phy_post_proc
branch
from
f65d3e5
to
52eca3a
Compare
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Dec 28, 2018
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Dec 28, 2018
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
XuHuaiyu
reviewed
Dec 29, 2018
…and move buildProjBelowAgg from executor to planner
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
zz-jason
added
status/LGT2
|
/run-all-tests |
eurekaka
reviewed
Jan 3, 2019
|
|
||
| // If the mode is FinalMode, we do not need to wrap cast upon the args, | ||
| // since the types of the args are already the expected. | ||
| if len(aggFuncs) > 0 && aggFuncs[0].Mode != aggregation.FinalMode { |
There was a problem hiding this comment.
@eurekaka Seems you're right.
There was a problem hiding this comment.
Should I push another PR to fix these two problems? 🤔
| } | ||
|
|
||
| child := aggPlan.Children()[0] | ||
| prop := aggPlan.GetChildReqProps(0).Clone() |
There was a problem hiding this comment.
prop would not be used anymore since we have finished physical optimization, so we can just set it nil?
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
Feb 15, 2019
…and move buildProjBelowAgg from executor to planner (pingcap#8828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add a post process function after DoOptimize() in package "planner/core". (#8713)
In this post process, we can:
So after this code change, the plan in explain xx is equals to explain analyze xx, and the plan generation is back to the "planner" package.
Hope this can make the code more readable and maintainable.
What is changed and how it works?
Check List
Tests
This change is