Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: throw "too big precision" error for CAST(AS TIME) (#8907) #9058

Merged
merged 3 commits into from Jan 15, 2019

Conversation

@zz-jason
Copy link
Member

commented Jan 15, 2019

cherrypick #8907 to release 2.1

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@zz-jason zz-jason requested review from eurekaka and XuHuaiyu Jan 15, 2019
Copy link
Contributor

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Member

left a comment

LGTM

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Jan 15, 2019
@zz-jason zz-jason merged commit 8780814 into pingcap:release-2.1 Jan 15, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zz-jason zz-jason deleted the zz-jason:cherrpick/2.1-cast-as-time branch Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.