Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle empty input and improve compatibility for `format` (#8797) #9235

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@zz-jason
Copy link
Member

zz-jason commented Jan 31, 2019

cherry pick #8797 to release 2.1

@zz-jason

This comment has been minimized.

Copy link
Member Author

zz-jason commented Jan 31, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala zimulala added the status/LGT1 label Feb 1, 2019

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka eurekaka added status/LGT2 and removed status/LGT1 labels Feb 1, 2019

@zz-jason zz-jason merged commit 5fed205 into pingcap:release-2.1 Feb 1, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:cherrpick/2.1-kenan-format branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.