Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl :fix cancel add/drop partitioned table ddl job #9376

Merged
merged 1 commit into from
Feb 21, 2019
Merged

ddl :fix cancel add/drop partitioned table ddl job #9376

merged 1 commit into from
Feb 21, 2019

Conversation

ciscoxll
Copy link
Contributor

What problem does this PR solve?

Cherry pick #8938

What is changed and how it works?

Check List

Tests

  • Unit test

@ciscoxll
Copy link
Contributor Author

@crazycs520 @zimulala PTAL.

crazycs520
crazycs520 reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@ciscoxll ciscoxll added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2019
@ciscoxll
Copy link
Contributor Author

@winkyao @zimulala PTAL.

zimulala
zimulala approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 21, 2019
@zimulala zimulala merged commit 29a48ae into pingcap:release-2.1 Feb 21, 2019
@ciscoxll ciscoxll deleted the cancel-add-partition branch February 21, 2019 03:49
@ciscoxll ciscoxll removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ciscoxll @crazycs520 @zimulala @you06 @sre-bot