Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: refine cancel modify column, add/drop foreign key rollback #9419

Merged
merged 11 commits into from
Feb 27, 2019
Merged

ddl: refine cancel modify column, add/drop foreign key rollback #9419

merged 11 commits into from
Feb 27, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

refine cancel modify column rollback and test.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

@crazycs520
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Feb 22, 2019 •
edited
Loading

Codecov Report

Merging #9419 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9419      +/-   ##
==========================================
+ Coverage    67.4%   67.41%   +<.01%     
==========================================
  Files         373      373              
  Lines       78557    78542      -15     
==========================================
- Hits        52954    52948       -6     
+ Misses      20844    20835       -9     
  Partials     4759     4759
Impacted Files Coverage Δ
util/admin/admin.go 67.32% <0%> (+1.46%) ⬆️
ddl/rollingback.go 64.91% <100%> (+1.07%) ⬆️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
executor/join.go 79.06% <0%> (-0.52%) ⬇️
executor/executor.go 68.16% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8369ed2...9262d43. Read the comment docs.

winkyao
winkyao reviewed Feb 22, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala reviewed Feb 22, 2019
View reviewed changes
ddl/ddl_worker_test.go Outdated Show resolved Hide resolved
zimulala
zimulala reviewed Feb 25, 2019
View reviewed changes
util/admin/admin.go Outdated Show resolved Hide resolved
@crazycs520 crazycs520 changed the title ddl: refine cancel modify column rollback ddl: refine cancel modify column, add/drop foreign key rollback Feb 25, 2019
@winkyao
Copy link
Contributor

winkyao commented Feb 26, 2019

@zimulala PTAL

zimulala
zimulala reviewed Feb 26, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 26, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

xiekeyi98
xiekeyi98 approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 merged commit c8c92e2 into pingcap:master Feb 27, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Mar 7, 2019
@crazycs520
ddl: refine cancel modify column, add/drop foreign key rollback (ping…
0eb1cf5 
…cap#9419)
@crazycs520 crazycs520 mentioned this pull request Mar 7, 2019
Merged
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Mar 8, 2019
@crazycs520
ddl: refine cancel modify column, add/drop foreign key rollback (ping…
2d46fcc 
…cap#9419)
@crazycs520 crazycs520 mentioned this pull request Mar 8, 2019
Merged
zz-jason pushed a commit that referenced this pull request Mar 9, 2019
@crazycs520 @zz-jason
ddl: refine cancel modify column, add/drop foreign key rollback (#9419)…
ea99709 
… (#9603)
zz-jason pushed a commit that referenced this pull request Mar 9, 2019
@crazycs520 @zz-jason
ddl: refine cancel modify column, add/drop foreign key rollback (#9419)…
5519eae 
… (#9613)
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@winkyao winkyao winkyao left review comments

@xiekeyi98 xiekeyi98 xiekeyi98 approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crazycs520 @codecov-io @winkyao @zimulala @xiekeyi98 @you06