tidb: fix build on Go1.12 #9557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go get -u github.com/pingcap/pd@3.0.0-alpha
xiekeyi98
reviewed
Mar 5, 2019
| @@ -63,6 +63,10 @@ var ( | |||
| ) | |||
|
|
|||
| func (s *testSuite) TestFailNewSession(c *C) { | |||
| // New version of clientv3 can not test use this unix socket. | |||
There was a problem hiding this comment.
Is it possible that we use api_gate_way to replace it?
|
After #9299 is merged and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After I try Go1.12, I meet this problem
#9299 (comment)
go mod tidywill upgrade the pd version to 2.1.5, and tidb fails to build with pd@2.1.5I expect tidb to build on Go1.12
What is changed and how it works?
pd 2.1.5 doesn't not employ Go module, specify tidb to use pd@3.0.0-alpha
Check List
Tests