Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: use `Column.UniqueID` in `conditionChecker` of ranger (#8236) #9587

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Mar 7, 2019

cherry-pick #8236

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

XuHuaiyu commented Mar 7, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@XuHuaiyu XuHuaiyu requested review from zz-jason and eurekaka Mar 7, 2019

c.Assert(fmt.Sprintf("%s", conds), Equals, tt.accessConds, Commentf("wrong access conditions for expr: %s", tt.exprStr))
result, err := ranger.BuildColumnRange(conds, new(stmtctx.StatementContext), col.RetType)
c.Assert(err, IsNil)
got := fmt.Sprintf("%v", result)
c.Assert(got, Equals, tt.resultStr, Commentf("different for expr %s, col: %v", tt.exprStr, col))
}
}

func (s *testRangerSuite) TestIndexRangeElimininatedProjection(c *C) {

This comment has been minimized.

Copy link
@eurekaka

eurekaka Mar 7, 2019

Contributor

We should remove this test case, since 2.1 does not have optimization to simplify ifnull() expression, so this test would fail.

This comment has been minimized.

Copy link
@zz-jason

zz-jason Mar 7, 2019

Member

How about keeping the test and modifying the test expect result?

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

XuHuaiyu commented Mar 7, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka eurekaka added the status/LGT1 label Mar 7, 2019

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason merged commit bc42d7f into pingcap:release-2.1 Mar 7, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.