Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix window func support #9605

Merged
merged 4 commits into from Mar 7, 2019

Conversation

AndrewDi
Copy link
Contributor

@AndrewDi AndrewDi commented Mar 7, 2019

What problem does this PR solve?

fix bug #9552

What is changed and how it works?

Keep tidb_enable_window_function variable with view parser.

Check List

Tests

  • Unit test

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Mar 7, 2019

@winoros @XuHuaiyu PTAL

@zz-jason zz-jason added contribution This PR is from a community contributor. type/bug-fix This PR fixes a bug. sig/planner SIG: Planner labels Mar 7, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from winoros and alivxxx March 7, 2019 15:07
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2019
@zz-jason zz-jason added this to In progress in window function via automation Mar 7, 2019
@zz-jason
Copy link
Member

zz-jason commented Mar 7, 2019

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #9605 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9605      +/-   ##
==========================================
+ Coverage   67.31%   67.31%   +<.01%     
==========================================
  Files         376      376              
  Lines       78967    78969       +2     
==========================================
+ Hits        53153    53159       +6     
+ Misses      21059    21057       -2     
+ Partials     4755     4753       -2
Impacted Files Coverage Δ
planner/core/logical_plan_builder.go 78.96% <100%> (+0.02%) ⬆️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
ddl/delete_range.go 77.77% <0%> (ø) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548afb0...b75497c. Read the comment docs.

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

window function automation moved this from In progress to Reviewer approved Mar 7, 2019
@winoros winoros merged commit e6b1c4c into pingcap:master Mar 7, 2019
window function automation moved this from Reviewer approved to Done Mar 7, 2019
@AndrewDi AndrewDi deleted the view/fix_windows_func_support branch March 11, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix This PR fixes a bug.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants