Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix window func support #9605

Merged
merged 4 commits into from Mar 7, 2019

Conversation

4 participants
@AndrewDi
Copy link
Contributor

AndrewDi commented Mar 7, 2019

What problem does this PR solve?

fix bug #9552

What is changed and how it works?

Keep tidb_enable_window_function variable with view parser.

Check List

Tests

  • Unit test

AndrewDi added some commits Mar 7, 2019

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Mar 7, 2019

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason requested review from winoros and lamxTyler Mar 7, 2019

@zz-jason zz-jason added the status/LGT1 label Mar 7, 2019

@zz-jason zz-jason added this to In progress in window function via automation Mar 7, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 7, 2019

/run-all-tests

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #9605 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9605      +/-   ##
==========================================
+ Coverage   67.31%   67.31%   +<.01%     
==========================================
  Files         376      376              
  Lines       78967    78969       +2     
==========================================
+ Hits        53153    53159       +6     
+ Misses      21059    21057       -2     
+ Partials     4755     4753       -2
Impacted Files Coverage Δ
planner/core/logical_plan_builder.go 78.96% <100%> (+0.02%) ⬆️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
ddl/delete_range.go 77.77% <0%> (ø) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548afb0...b75497c. Read the comment docs.

@winoros
Copy link
Member

winoros left a comment

lgtm

window function automation moved this from In progress to Reviewer approved Mar 7, 2019

@winoros

winoros approved these changes Mar 7, 2019

@winoros winoros merged commit e6b1c4c into pingcap:master Mar 7, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Mar 7, 2019

@AndrewDi AndrewDi deleted the AndrewDi:view/fix_windows_func_support branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.