Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix Error message about `select ... inner join` is not same with MYSQL.(#9573) #9626

Merged
merged 2 commits into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@AndrewDi
Copy link
Contributor

AndrewDi commented Mar 10, 2019

What problem does this PR solve?

Fix issue #9573

What is changed and how it works?

When check join ErrNonUniqTable, we should check both tablesource name and table alias.

Check List

Tests

  • Unit test

AndrewDi added some commits Mar 10, 2019

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Mar 10, 2019

@xiekeyi98 PTAL

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #9626 into master will increase coverage by 0.0092%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master      #9626        +/-   ##
================================================
+ Coverage   67.3963%   67.4055%   +0.0092%     
================================================
  Files           374        374                
  Lines         78942      78949         +7     
================================================
+ Hits          53204      53216        +12     
+ Misses        20986      20985         -1     
+ Partials       4752       4748         -4
@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Mar 10, 2019

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 10, 2019

LGTM

@xiekeyi98
Copy link
Member

xiekeyi98 left a comment

LGTM,Thank you.

@xiekeyi98 xiekeyi98 merged commit 3045359 into pingcap:master Mar 10, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 67.4055% (+0.0092%) compared to d672477
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndrewDi AndrewDi deleted the AndrewDi:fix_join_error_msg branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.