planner: Fix Error message about select ... inner join is not same with MYSQL.(#9573)
#9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiekeyi98 PTAL |
Codecov Report
@@ Coverage Diff @@
## master #9626 +/- ##
================================================
+ Coverage 67.3963% 67.4055% +0.0092%
================================================
Files 374 374
Lines 78942 78949 +7
================================================
+ Hits 53204 53216 +12
+ Misses 20986 20985 -1
+ Partials 4752 4748 -4 |
|
/run-all-tests |
|
LGTM |
zz-jason
added
contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix issue #9573
What is changed and how it works?
When check join ErrNonUniqTable, we should check both tablesource name and table alias.
Check List
Tests