Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support variable `log_bin` #9634

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
6 participants
@WangXiangUSTC
Copy link
Member

WangXiangUSTC commented Mar 11, 2019

What problem does this PR solve?

support variable log_bin

What is changed and how it works?

cherry-pick from #9343,
and resolve some conflicts

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to be included in the release note
@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Mar 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Mar 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 11, 2019

LGTM

@zz-jason zz-jason requested a review from jackysp Mar 11, 2019

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Mar 11, 2019

@jackysp
Copy link
Member

jackysp left a comment

LGTM
I think we must update our document for this PR.

@jackysp jackysp merged commit e21d15e into pingcap:release-2.1 Mar 11, 2019

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@WangXiangUSTC WangXiangUSTC deleted the WangXiangUSTC:xiang/log_bin branch Mar 12, 2019

@bqwzhl20

This comment has been minimized.

Copy link

bqwzhl20 commented Mar 20, 2019

How to set variable log_bin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.