Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: check no partitions error when create partition table (#9531) #9663

Merged
merged 7 commits into from
Mar 23, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #9531, release 2.1 only support range partition, so only cherry-pick some part code.

What is changed and how it works?

Check List

Tests

  • Unit test

@crazycs520
Copy link
Contributor Author

@tiancaiamao @winkyao PTAL

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed component/DDL-need-LGT3 status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2019
@zimulala
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit d8520b3 into pingcap:release-2.1 Mar 23, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants