Skip to content

ddl: remove wait time after canceling a job#9768

Merged
zz-jason merged 3 commits into
pingcap:release-2.1from
zimulala:zimuxia/ddl-save-time
Mar 19, 2019
Merged

ddl: remove wait time after canceling a job#9768
zz-jason merged 3 commits into
pingcap:release-2.1from
zimulala:zimuxia/ddl-save-time

Conversation

@zimulala
Copy link
Copy Markdown
Contributor

cherry-pick #9648 to v2.1

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@zimulala
Copy link
Copy Markdown
Contributor Author

PTAL @crazycs520 @xiekeyi98

@zimulala
Copy link
Copy Markdown
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Copy Markdown
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST LGTM.

Comment thread ddl/db_integration_test.go
@zimulala
Copy link
Copy Markdown
Contributor Author

PTAL @xiekeyi98

Copy link
Copy Markdown
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2019
Copy link
Copy Markdown
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 346009f into pingcap:release-2.1 Mar 19, 2019
@zimulala zimulala deleted the zimuxia/ddl-save-time branch March 19, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants