Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PromQL may be inaccurate with higher quantiles #8076

Closed
CalvinNeo opened this issue Sep 11, 2023 · 1 comment · Fixed by #8084 or #8446
Closed

PromQL may be inaccurate with higher quantiles #8076

CalvinNeo opened this issue Sep 11, 2023 · 1 comment · Fixed by #8084 or #8446
Assignees
@CalvinNeo
Labels
affects-5.1 affects-5.4 affects-6.1 affects-6.5 affects-7.1 affects-7.5 component/storage severity/moderate type/bug The issue is confirmed as a bug.

Comments

@CalvinNeo
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

See m3db/m3#3706

73e99b33-eea0-43ef-af8e-bf16250d2f30

b8aa9e83-6be9-4e83-8ecc-7cf7a8e69121

Use something like

histogram_quantile(1.0, sum(round(1000000000*rate(xxx{}[5m]))) by (le) / 1000000000)

When using histogram_quantile 1.0 with sum(rate)

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)
@CalvinNeo CalvinNeo added the type/bug The issue is confirmed as a bug. label Sep 11, 2023
@CalvinNeo CalvinNeo self-assigned this Sep 11, 2023
@CalvinNeo
Copy link
Member Author

tiflash_raft_wait_index_duration_seconds_bucket
tiflash_raft_read_index_duration_seconds_bucket
tiflash_raft_apply_write_command_duration_seconds_bucket
tiflash_raft_eager_gc_duration_seconds_bucket
tiflash_raft_upstream_latency_bucket
tiflash_storage_checkpoint_seconds_bucket
tiflash_pipeline_task_execute_max_time_seconds_per_round_bucket
tiflash_storage_io_limiter_pending_seconds_bucket
tiflash_storage_page_write_duration_seconds_bucket
tiflash_storage_page_gc_duration_seconds_bucket

@CalvinNeo CalvinNeo mentioned this issue Sep 13, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 13, 2023
@CalvinNeo
Fix promql with high quantiles (#8084)
e09ec61 
close #8076
This was referenced Sep 13, 2023
Closed
Closed
Closed
Closed
This was referenced Dec 6, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 6, 2023
@JaySon-Huang
Raft: Add identifier to logger when wait index happens (#8446)
713bca0 
close #8076, close #8448
ti-chi-bot bot pushed a commit that referenced this issue Dec 7, 2023
@JaySon-Huang
Raft: Add identifier to logger when wait index happens(release-7.1) (#…
bb529e6 
…8473)

close #8076, close #8448
This was referenced Dec 7, 2023
Merged
Merged
Closed
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@ti-chi-bot
Raft: Add identifier to logger when wait index happens(release-7.5) (#…
ccd0b84 
…8473) (#8474)

close #8076, close #8448
ti-chi-bot bot pushed a commit that referenced this issue Dec 20, 2023
@ti-chi-bot
Raft: Add identifier to logger when wait index happens(release-6.5) (#…
170bc61 
…8473) (#8475)

close #8076, close #8448
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinNeo CalvinNeo

Labels
affects-5.1 affects-5.4 affects-6.1 affects-6.5 affects-7.1 affects-7.5 component/storage severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
2 participants
@JaySon-Huang @CalvinNeo