Fix the potential concurrency problem when clone the shared delta index (#2030)

[ti-srebot]

cherry-pick #2030 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2033

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2033:release-5.0-1076ba58a438

---

What problem does this PR solve?

Issue Number: close #2023

Problem Summary: The clone process of the DeltaIndex is not protected by mutex.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch:

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

Release note

• Fix the potential concurrency problem when clone the shared delta index.

[flowbehappy]

LGTM

[JaySon-Huang]

/run-all-tests

[JaySon-Huang]

In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.h:10:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/FlushDelta.cpp:6:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h: In member function ‘DB::DM::DeltaIndexPtr DB::DM::DeltaIndex::tryCloneInner(size_t, const Updates*)’:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:110:120: error: ‘placed_deletes_copy’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         : id(++NEXT_DELTA_INDEX_ID), delta_tree(delta_tree_), placed_rows(placed_rows_), placed_deletes(placed_deletes_)
                                                                                                                        ^
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.h:10:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/FlushDelta.cpp:6:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:76:22: note: ‘placed_deletes_copy’ was declared here
         size_t       placed_deletes_copy;
                      ^~~~~~~~~~~~~~~~~~~
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.h:10:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/FlushDelta.cpp:6:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:110:120: error: ‘placed_rows_copy’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         : id(++NEXT_DELTA_INDEX_ID), delta_tree(delta_tree_), placed_rows(placed_rows_), placed_deletes(placed_deletes_)
                                                                                                                        ^
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/DeltaValueSpace.h:10:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Delta/FlushDelta.cpp:6:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:75:22: note: ‘placed_rows_copy’ was declared here
         size_t       placed_rows_copy;
                      ^~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [dbms/CMakeFiles/dbms.dir/src/Storages/DeltaMerge/Delta/FlushDelta.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndexManager.h:3:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Segment.cpp:10:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h: In member function ‘std::pair<std::shared_ptr<DB::DM::DeltaIndex>, bool> DB::DM::Segment::ensurePlace(const DB::DM::DMContext&, const StableSnapshotPtr&, const DeltaValueReaderPtr&, const RowKeyRanges&, DB::UInt64) const’:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:110:120: error: ‘placed_deletes_copy’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         : id(++NEXT_DELTA_INDEX_ID), delta_tree(delta_tree_), placed_rows(placed_rows_), placed_deletes(placed_deletes_)
                                                                                                                        ^
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndexManager.h:3:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Segment.cpp:10:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:76:22: note: ‘placed_deletes_copy’ was declared here
         size_t       placed_deletes_copy;
                      ^~~~~~~~~~~~~~~~~~~
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndexManager.h:3:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Segment.cpp:10:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:110:120: error: ‘placed_rows_copy’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         : id(++NEXT_DELTA_INDEX_ID), delta_tree(delta_tree_), placed_rows(placed_rows_), placed_deletes(placed_deletes_)
                                                                                                                        ^
In file included from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndexManager.h:3:0,
                 from /data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/Segment.cpp:10:
/data1/jaysonhuang/tics-master/dbms/src/Storages/DeltaMerge/DeltaIndex.h:75:22: note: ‘placed_rows_copy’ was declared here
         size_t       placed_rows_copy;
                      ^~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

g++ throw error while compilng

[JaySon-Huang]

/run-all-tests

[lidezhu]

/run-all-tests

[lidezhu]

/run-all-tests