Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline: use notify instead of polling for SharedQueue #8875

Merged
merged 50 commits into from
May 20, 2024
Merged

Pipeline: use notify instead of polling for SharedQueue #8875

merged 50 commits into from
May 20, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 28, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8869

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 28, 2024

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 28, 2024

wait for #8872

@SeaRise SeaRise changed the title Pipeline: use notify instead of polling for SharedQueue WIP: Pipeline: use notify instead of polling for SharedQueue Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@SeaRise SeaRise mentioned this pull request Mar 28, 2024
Open
8 tasks
SeaRise
SeaRise commented May 8, 2024
View reviewed changes
dbms/src/Operators/Operator.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/Operator.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/Operator.cpp Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor Author

SeaRise commented May 8, 2024

/cc @gengliqi

@ti-chi-bot ti-chi-bot bot requested a review from gengliqi May 8, 2024 06:56
gengliqi
gengliqi approved these changes May 8, 2024
View reviewed changes
dbms/src/Common/LooseBoundedMPMCQueue.h
return element.data;
}

template <typename U>
ALWAYS_INLINE void pushFront(U && data)
ALWAYS_INLINE bool pushFront(U && data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding comments about the return value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has added comment If returns true, then notify writers afterward; if false, no need to notify writers..

@SeaRise
Copy link
Contributor Author

SeaRise commented May 10, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented May 10, 2024

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker May 10, 2024 02:27
windtalker
windtalker approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-08 10:31:40.298717836 +0000 UTC m=+1044454.055853410: ☑️ agreed by gengliqi.
  • 2024-05-20 06:11:54.469685564 +0000 UTC m=+2065668.226821137: ☑️ agreed by windtalker.

@SeaRise
Copy link
Contributor Author

SeaRise commented May 20, 2024

/merge

@SeaRise
Copy link
Contributor Author

SeaRise commented May 20, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented May 20, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SeaRise,gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SeaRise
Copy link
Contributor Author

SeaRise commented May 20, 2024

/test all

@SeaRise
Copy link
Contributor Author

SeaRise commented May 20, 2024

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 242f2d9 into pingcap:master May 20, 2024
5 checks passed
@SeaRise SeaRise deleted the shared_queue_notify branch May 20, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeaRise @windtalker @gengliqi