Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline: use notify instead of polling for UnorderedSourceOp #8872

Merged
merged 21 commits into from
Mar 29, 2024
Merged

Pipeline: use notify instead of polling for UnorderedSourceOp #8872

merged 21 commits into from
Mar 29, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8869

Problem Summary:

What is changed and how it works?

add a new status WAIT_FOR_NOTIFY to register task to a notify future.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 26, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 26, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 26, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 26, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 27, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 27, 2024

/run-unit-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 27, 2024

/run-unit-test

@SeaRise SeaRise requested a review from gengliqi March 27, 2024 07:24
@SeaRise @gengliqi
Update dbms/src/Storages/DeltaMerge/ReadThread/WorkQueue.h
20d297d 
Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
@SeaRise SeaRise requested a review from gengliqi March 27, 2024 10:25
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 27, 2024
This was referenced Mar 28, 2024
Closed
Merged
windtalker
windtalker approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 29, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 29, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 10:28:22.002720595 +0000 UTC m=+2063729.024966992: ☑️ agreed by gengliqi.
  • 2024-03-29 02:02:49.769505613 +0000 UTC m=+2206196.791752001: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 29, 2024

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 29, 2024

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 29, 2024

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 29, 2024

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit aa67e0c into pingcap:master Mar 29, 2024
6 checks passed
@SeaRise SeaRise deleted the notify_instead_of_pollinh branch March 29, 2024 07:07
ti-chi-bot bot pushed a commit that referenced this pull request Apr 2, 2024
@SeaRise
fix the issue that building tiflash in mac fail introduced by #8872 (#…
93d7395 
…8888)

ref #6233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeaRise @windtalker @gengliqi