Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventFeed may miss some regions when region is splitting #303

Closed
MyonKeminta opened this issue Mar 2, 2020 · 0 comments · Fixed by #308
Closed

EventFeed may miss some regions when region is splitting #303

MyonKeminta opened this issue Mar 2, 2020 · 0 comments · Fixed by #308
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. type/bug This is a bug.
Projects
Question and Bug Reports

Comments

@MyonKeminta
Copy link
Contributor

The function partialRegionFeed (in cdc/kv/client.go) accepts a region info from parameter and may reload region info from region cache before sending request. So it's possible that the region has changed after a split. As a result it will get a smaller region after calling regionCache.LocateKey that doesn't cover the range hold by the parameter regionInfo, so the remaining part of the range will be missing.
@MyonKeminta MyonKeminta added type/bug This is a bug. component/kv-client TiKV kv log client component. labels Mar 2, 2020
@MyonKeminta MyonKeminta mentioned this issue Mar 4, 2020
Merged
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Mar 9, 2022
amyangfei pushed a commit to amyangfei/tiflow that referenced this issue May 6, 2022
@GMHDBJD
dmJobmaster: add checkpoint agent (pingcap#303)
1e4ae61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. type/bug This is a bug.
Projects
Question and Bug Reports
Need Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: Implement batch client MyonKeminta/ticdc
2 participants
@MyonKeminta @AkiraXie