client: Implement batch client #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Closed
MyonKeminta
changed the title
amyangfei
added
component/kv-client
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
amyangfei
reviewed
Mar 11, 2020
Co-Authored-By: amyangfei <amyangfei@gmail.com>
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 28.39% 29.69% +1.29%
==========================================
Files 59 55 -4
Lines 5558 5261 -297
==========================================
- Hits 1578 1562 -16
+ Misses 3843 3560 -283
- Partials 137 139 +2
Continue to review full report at Codecov.
|
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
amyangfei
pushed a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR implements batch client to reuse one stream for multiple regions.
Fixes #292
Also fixes #303
What is changed and how it works?
This PR switches kvproto to https://github.com/5kbpers/kvproto/tree/cdc-batch-service . For each invoking to
EventFeed, at most one stream will be connected to each TiKV instance.There will be one sender goroutine that dispatches requests to each stream, one receiver goroutine for each stream receives the events from it. However, different from the original design, there are still one goroutine for each region. The receiver goroutines doesn't process the events by themselves, instead, they dispatches the events to the goroutines for each region. It's because to maintain the region's states in a single goroutine is complicated, and to make it work as soon as possible, currently these goroutines are still kept. I'll continue working on further refactoring and optimizing.
In this PR, error handling still needs polishing.
Check List
Tests
Side effects