Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the calculation method of ticdc's gc saftpoint #8403

Closed
nongfushanquan opened this issue Mar 1, 2023 · 4 comments · Fixed by #8464
Closed

optimize the calculation method of ticdc's gc saftpoint #8403

nongfushanquan opened this issue Mar 1, 2023 · 4 comments · Fixed by #8464
Assignees
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. type/enhancement This is a enhancement PR

Comments

@nongfushanquan
Copy link
Contributor

Is your feature request related to a problem?

As for one upstream in lots of changefeeds scenarios, if one changefeed fails and other changefeed work normal, ticdc will ignore the checkpoint ts of the failed changefeed and use the the checkpoint ts of the normal one as gc safe point. So the tidb would gc some data before the customer handle the error.

Describe the feature you'd like

if one changefeed fails, the gc safe-point can hold for 24h . The calculation method is as followed:

If changefeed1: failed (check point ts = ts1),changefeed2 normal checkpoint ts = ts2.
Then Gc safepoint = min( ts2, max( ts1, currentPDts - 24h))

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response

@nongfushanquan nongfushanquan added the type/feature Issues about a new feature label Mar 1, 2023
@nongfushanquan
Copy link
Contributor Author

/area ticdc

@ti-chi-bot ti-chi-bot added the area/ticdc Issues or PRs related to TiCDC. label Mar 1, 2023
@nongfushanquan
Copy link
Contributor Author

/assign @charleszheng44

@nongfushanquan
Copy link
Contributor Author

/label affects-7.1

@nongfushanquan
Copy link
Contributor Author

/label affects-6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. type/enhancement This is a enhancement PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants