Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table sink can never release memory quota when sink factory fails #9450

Closed
hicqu opened this issue Jul 31, 2023 · 0 comments · Fixed by #9449
Closed

Table sink can never release memory quota when sink factory fails #9450

hicqu opened this issue Jul 31, 2023 · 0 comments · Fixed by #9449
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/moderate This is a moderate bug. type/bug This is a bug.
Projects
Question and Bug Reports

Comments

@hicqu
Copy link
Contributor

hicqu commented Jul 31, 2023

What did you do?

  1. create a cdc cluster and cdc changefeed;
  2. make the downstream sink block, wait for memory quota gets full;
  3. inject an error to the downstream sink;
  4. recover the downstream sink.

What did you expect to see?

Table sinks can be re-created successfully.

What did you see instead?

Table sinks can never be re-created successfully. And memory quota is always full.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
@hicqu hicqu added type/bug This is a bug. area/ticdc Issues or PRs related to TiCDC. labels Jul 31, 2023
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Jul 31, 2023
@hicqu hicqu mentioned this issue Jul 31, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #9449 Aug 1, 2023
Question and Bug Reports automation moved this from Need Triage to Done Aug 1, 2023
ti-chi-bot bot pushed a commit that referenced this issue Aug 1, 2023
@hicqu
sink(cdc): close table sinks when sink factory fails (#9449)
0deaa50 
close #9450
This was referenced Aug 1, 2023
Merged
Merged
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Aug 2, 2023
@hicqu
sink(cdc): close table sinks when sink factory fails (pingcap#9449)
50862a7 
close pingcap#9450

Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this issue Aug 2, 2023
@ti-chi-bot
sink(cdc): close table sinks when sink factory fails (#9449) (#9464)
8228ded 
close #9450
CharlesCheung96 pushed a commit to CharlesCheung96/tiflow that referenced this issue Aug 11, 2023
@ti-chi-bot @CharlesCheung96
sink(cdc): close table sinks when sink factory fails (pingcap#9449) (p…
2caa14c 
…ingcap#9464)

close pingcap#9450
@CharlesCheung96 CharlesCheung96 mentioned this issue Aug 11, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 14, 2023
@ti-chi-bot
sink(cdc): close table sinks when sink factory fails (#9449) (#9465)
fe96b21 
close #9450
@nongfushanquan nongfushanquan mentioned this issue Aug 22, 2023
Merged
17 tasks
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this issue Aug 29, 2023
@hicqu @3AceShowHand
sink(cdc): close table sinks when sink factory fails (pingcap#9449)
fa2a074 
close pingcap#9450
@nongfushanquan nongfushanquan mentioned this issue Sep 28, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/moderate This is a moderate bug. type/bug This is a bug.
Projects
Question and Bug Reports
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sink(cdc): close table sinks when sink factory fails hicqu/ticdc
1 participant
@hicqu