Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add prow OWNERS for dm and engine modules #11101

Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented May 15, 2024

What problem does this PR solve?

Issue Number: close #11100

What is changed and how it works?

Add prow OWNERS files to dm and engine code paths.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 15, 2024
@wuhuizuo wuhuizuo force-pushed the ci/add-owners-for-dm-and-engine-modules branch from 93e73b8 to 48bf383 Compare May 15, 2024 08:21
approvers:
- sig-approvers-dm
labels:
- area/dm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the bot will add the label area/dm automatically when changes hit this scope.

@wuhuizuo
Copy link
Contributor Author

/cc Benjamin2037 D3Hunter GMHDBJD lance6716

@wuhuizuo
Copy link
Contributor Author

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@wuhuizuo: once the present PR merges, I will cherry-pick it on top of release-6.5/release-7.1/release-7.5/release-8.1 in the new PR and assign it to you.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-15 08:25:37.843414907 +0000 UTC m=+1641691.600550477: ☑️ agreed by lance6716.
  • 2024-05-15 08:28:20.577008088 +0000 UTC m=+1641854.334143660: ☑️ agreed by D3Hunter.

@wuhuizuo
Copy link
Contributor Author

/retest

Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,D3Hunter,GMHDBJD,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 2d5d1c3 into pingcap:master May 15, 2024
10 checks passed
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.1: #11104.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.5: #11105.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #11106.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #11107.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@wuhuizuo wuhuizuo deleted the ci/add-owners-for-dm-and-engine-modules branch May 16, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup OWNERS files in top folders
6 participants