Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: log slow conflict detect every 60s (#11251) #11286

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11251

What problem does this PR solve?

Issue Number: close #11271

What is changed and how it works?

Log slow conflict detect every 60s.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Jun 11, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels Jun 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 30, 2024
@hicqu
Copy link
Contributor

hicqu commented Jul 31, 2024

/retest

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@2bd57a7). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.8186% <0.0000%> (?)
dm 51.3596% <0.0000%> (?)
engine 63.4373% <0.0000%> (?)
Flag Coverage Δ
unit 57.5310% <32.1428%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11286   +/-   ##
================================================
  Coverage               ?   57.5310%           
================================================
  Files                  ?        853           
  Lines                  ?     125946           
  Branches               ?          0           
================================================
  Hits                   ?      72458           
  Misses                 ?      48076           
  Partials               ?       5412           

@hicqu
Copy link
Contributor

hicqu commented Jul 31, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 739708f into pingcap:release-8.1 Jul 31, 2024
26 of 27 checks passed
@hicqu hicqu deleted the cherry-pick-11251-to-release-8.1 branch July 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants