-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncer(dm): Ignore SET statement for MariaDB (#10207) #11440
syncer(dm): Ignore SET statement for MariaDB (#10207) #11440
Conversation
Without this the following happens: ``` [2023/11/29 11:17:55.229 +02:00] [DPANIC] [tracker.go:206] ["unexpected statement type"] [task=demo-mariadb-tidb] [unit="binlog replication"] [component=schema-tracker] [task=demo-mariadb-tidb] [type=*ast.SetStmt] [stack="github.com/pingcap/tiflow/dm/pkg/schema.(*Tracker).Exec\n\tgithub.com/pingcap/tiflow/dm/pkg/schema/tracker.go:206\ngithub.com/pingcap/tiflow/dm/syncer.(*Syncer).loadTableStructureFromDump\n\tgithub.com/pingcap/tiflow/dm/syncer/syncer.go:3068\ngithub.com/pingcap/tiflow/dm/syncer.(*Syncer).Run\n\tgithub.com/pingcap/tiflow/dm/syncer/syncer.go:1856\ngithub.com/pingcap/tiflow/dm/syncer.(*Syncer).Process\n\tgithub.com/pingcap/tiflow/dm/syncer/syncer.go:757"] [2023/11/29 11:17:55.231 +02:00] [INFO] [syncer.go:1688] ["received ungraceful exit ctx, exit now"] [task=demo-mariadb-tidb] [unit="binlog replication"] panic: interface conversion: ast.StmtNode is *ast.SetStmt, not *ast.CreateTableStmt goroutine 1807 [running]: github.com/pingcap/tiflow/dm/syncer.(*Syncer).loadTableStructureFromDump(0xc000cb7200, {0x4a54438, 0xc00105dd10}) github.com/pingcap/tiflow/dm/syncer/syncer.go:3079 +0x1ce9 github.com/pingcap/tiflow/dm/syncer.(*Syncer).Run(0xc000cb7200, {0x4a54438?, 0xc00105dd10?}) github.com/pingcap/tiflow/dm/syncer/syncer.go:1856 +0xcd6 github.com/pingcap/tiflow/dm/syncer.(*Syncer).Process(0xc000cb7200, {0x4a54438, 0xc00105dcc0}, 0x0?) github.com/pingcap/tiflow/dm/syncer/syncer.go:757 +0x325 created by github.com/pingcap/tiflow/dm/worker.(*SubTask).run in goroutine 1707 github.com/pingcap/tiflow/dm/worker/subtask.go:242 +0x53b ```
Co-authored-by: lance6716 <lance6716@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #11440 +/- ##
================================================
Coverage ? 57.4473%
================================================
Files ? 852
Lines ? 125729
Branches ? 0
================================================
Hits ? 72228
Misses ? 48091
Partials ? 5410 |
/retest |
3 similar comments
/retest |
/retest |
/retest |
This is an automated cherry-pick of #10207
Without this the following happens:
What problem does this PR solve?
Issue Number: close #10206
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note