Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Add log configuration items to the config file #2182

Merged
merged 4 commits into from
Jun 30, 2021
Merged

config: Add log configuration items to the config file #2182

merged 4 commits into from
Jun 30, 2021

Conversation

SuperSupeng
Copy link
Contributor

What problem does this PR solve?

Add log configuration items to the config file. #1384

What is changed and how it works?

Add logFileMaxSize, logFileMaxDays and logFileMaxBackups items when load config file.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2021
@SuperSupeng
Copy link
Contributor Author

#2317 PR was closed for compatibility reasons. The configuration file is in this form to try to keep the TiCDC as consistent as possible with the TIDB configuration.

@SuperSupeng
Copy link
Contributor Author

/cc @leoppro

@ti-chi-bot ti-chi-bot requested a review from zier-one June 29, 2021 04:18
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2021
@SuperSupeng
Copy link
Contributor Author

/cc @overvenus

overvenus
overvenus approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jun 29, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4c06a8f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@SuperSupeng
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 284dd55 into pingcap:master Jun 30, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 30, 2021
@SuperSupeng @ti-chi-bot
This is an automated cherry-pick of pingcap#2182
b5aeb05 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2194.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2195.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2196.

3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Jul 9, 2021
@SuperSupeng @3AceShowHand
config: Add log configuration items to the config file (pingcap#2182)
bd185b1
ti-chi-bot added a commit that referenced this pull request Jul 9, 2021
@ti-chi-bot
config: Add log configuration items to the config file (#2182) (#2196)
7d0b75a
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
config: Add log configuration items to the config file (#2182) (#2195)
7cb8266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus overvenus approved these changes

@liuzix liuzix Awaiting requested review from liuzix

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuperSupeng @ti-chi-bot @amyangfei @overvenus