Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimal checkpointTS as gc safepoint to PD #487

Merged
merged 6 commits into from
Apr 27, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

close #482.

What is changed and how it works?

update minimal checkpointTS as gc safepoint to PD

Tests

  • No...

Code changes

  • Has interface methods change

Side effects

Related changes

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
cdc/owner.go Outdated Show resolved Hide resolved
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/owner.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor

please resolve the conflicts

cdc/owner.go Show resolved Hide resolved
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the LGT1 label Apr 26, 2020
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-io
Copy link

Codecov Report

Merging #487 into master will decrease coverage by 0.0228%.
The diff coverage is 0.0000%.

@@               Coverage Diff                @@
##             master       #487        +/-   ##
================================================
- Coverage   26.2199%   26.1971%   -0.0229%     
================================================
  Files            61         61                
  Lines          6373       6390        +17     
================================================
+ Hits           1671       1674         +3     
- Misses         4589       4603        +14     
  Partials        113        113                

@amyangfei amyangfei merged commit 8b17582 into pingcap:master Apr 27, 2020
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support update service GC safe point in TiCDC
5 participants