Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracker(dm): close and recreate tracker when pause and resume (#5350) #5415

Merged
merged 6 commits into from
Jun 16, 2022
Merged

tracker(dm): close and recreate tracker when pause and resume (#5350) #5415

merged 6 commits into from
Jun 16, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5350

What problem does this PR solve?

Issue Number: close #5344
fix #3734

What is changed and how it works?

as title. And when (re)create tracker, load all table structure from checkpoints

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fix a bug that after auto resume, DM will use more disk space.

@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#5350
a7d5fb8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels May 13, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2022
Merged
@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels May 13, 2022
@lance6716
Copy link
Contributor

/hold

remember #5678

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@lance6716
Copy link
Contributor

/run-dm-integration-test

@lance6716
Copy link
Contributor

/run-dm-integration-test

@lance6716
Copy link
Contributor

/run-dm-integration-test

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022
@lance6716
Copy link
Contributor

/run-all-tests

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b09096d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels Jun 16, 2022
@ti-chi-bot ti-chi-bot merged commit 060e880 into pingcap:release-5.4 Jun 16, 2022
@lance6716 lance6716 mentioned this pull request Jun 24, 2022
Closed
@heibaijian heibaijian added this to the v5.4.2 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lance6716 lance6716

Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ti-chi-bot @lance6716 @VelocityLight @heibaijian