Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncer(dm): update memory cache after FlushPointWithTableInfo #5678

Merged
merged 6 commits into from
Jun 1, 2022
Merged

syncer(dm): update memory cache after FlushPointWithTableInfo #5678

merged 6 commits into from
Jun 1, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 31, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

Check List

Tests

  • integration tests
  • Manual test
    test case downstream_more_column failed before this PR, and passed after this PR

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@lance6716: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2022
This was referenced May 31, 2022
Merged
Merged
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

2 similar comments
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@purelind
Copy link
Collaborator

/run-dm-integration-test

@purelind
Copy link
Collaborator

/run-dm-compatibility-tests

@purelind
Copy link
Collaborator

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716 lance6716 changed the title [WIP]syncer(dm): update memory cache after FlushPointWithTableInfo syncer(dm): update memory cache after FlushPointWithTableInfo Jun 1, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2022
@lance6716
Copy link
Contributor Author

https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/6386/pipeline

CI runs slowly thus failed

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

GMHDBJD
GMHDBJD approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/6390/pipeline

integration test passed

@lance6716 lance6716 merged commit ed6b98d into pingcap:release-5.3-20220414 Jun 1, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
@lance6716 lance6716 deleted the hotfixfix branch October 13, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-chi-bot @purelind @GMHDBJD @heibaijian