Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): mount float32 value correctly to avoid the precision lost. #8502

Merged
merged 14 commits into from
Mar 14, 2023
Merged

mounter(ticdc): mount float32 value correctly to avoid the precision lost. #8502

merged 14 commits into from
Mar 14, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8490

What is changed and how it works?

  • For float32 types, fetch it from thedatum by use the corresponding method.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix float32 types precision lost

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 Should cherry pick this PR to release-6.2 branch. needs-cherry-pick-release-6.3 Should cherry pick this PR to release-6.3 branch. needs-cherry-pick-release-6.4 Should cherry pick this PR to release-6.4 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 Should cherry pick this PR to release-6.6 branch. and removed do-not-merge/needs-triage-completed labels Mar 13, 2023
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@ti-chi-bot ti-chi-bot merged commit d30f48b into pingcap:master Mar 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #8513.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
15d7504 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
6f16bcb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.0: #8514.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #8515.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
bb4075e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #8516.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
c64d06f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8517.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
8df157c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
ca1ae4e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #8518.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8519.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
7cda91e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 14, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8502
34167a8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #8520.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #8521.

ti-chi-bot added a commit that referenced this pull request Mar 24, 2023
@ti-chi-bot
mounter(ticdc): mount float32 value correctly to avoid the precision …
2869997 
…lost. (#8502) (#8519)

close #8490
ti-chi-bot added a commit that referenced this pull request Apr 4, 2023
@ti-chi-bot
mounter(ticdc): mount float32 value correctly to avoid the precision …
77bc7e5 
…lost. (#8502) (#8517)

close #8490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

@sdojjy sdojjy Awaiting requested review from sdojjy

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 Should cherry pick this PR to release-6.2 branch. needs-cherry-pick-release-6.3 Should cherry pick this PR to release-6.3 branch. needs-cherry-pick-release-6.4 Should cherry pick this PR to release-6.4 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 Should cherry pick this PR to release-6.6 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loss of 'float' type values precision in the Kafka sink using 'canal-json' protocol
5 participants
@3AceShowHand @ti-chi-bot @amyangfei @sdojjy @overvenus