Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add strict optimist mode #9113

Merged
merged 17 commits into from Jun 13, 2023
Merged

dm: add strict optimist mode #9113

merged 17 commits into from Jun 13, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Jun 1, 2023

What problem does this PR solve?

Issue Number: close #9112

What is changed and how it works?

  • return error when get SkipAndWaitRedirect operator.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

support strict optimistic mode for incompatible DDL

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 1, 2023
@GMHDBJD GMHDBJD added the area/dm Issues or PRs related to DM. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 1, 2023
@GMHDBJD GMHDBJD changed the title dm: Add strict optimist mode dm: add strict optimist mode Jun 1, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 1, 2023

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 1, 2023

/test all

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 1, 2023

/test all

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 1, 2023

/test all

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 1, 2023

/test all

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 2, 2023

/test all

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 2, 2023

/test all

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 4, 2023

/test all

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2023
lichunzhu
lichunzhu approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-12 07:13:48.690393492 +0000 UTC m=+136578.145154780: ☑️ agreed by lance6716.
  • 2023-06-12 09:00:40.0584809 +0000 UTC m=+142989.513242211: ☑️ agreed by lichunzhu.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 12, 2023

/merge

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 12, 2023

/retest

4 similar comments
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 12, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/test verify

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/test dm-integration-test

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit b7ce4c2 into pingcap:master Jun 13, 2023
13 checks passed
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jun 13, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 13, 2023

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9212.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 13, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 13, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#9113
e0b48dc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@GMHDBJD GMHDBJD mentioned this pull request Jun 14, 2023
Merged
17 tasks
@ran-huang ran-huang mentioned this pull request Jun 20, 2023
Merged
17 tasks
@GMHDBJD GMHDBJD mentioned this pull request Jun 26, 2023
Merged
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Aug 10, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 10, 2023

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 10, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9540.

ti-chi-bot bot pushed a commit that referenced this pull request Aug 16, 2023
@ti-chi-bot
dm: add strict optimist mode (#9113) (#9212)
28b0657 
close #9112
ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@ti-chi-bot
dm: add strict optimist mode (#9113) (#9540)
ff869a6 
close #9112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm: add strict optimistic shard mode
4 participants
@GMHDBJD @ti-chi-bot @lance6716 @lichunzhu