Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add strict optimist mode (#9113) #9212

Merged
merged 6 commits into from Aug 16, 2023
Merged

dm: add strict optimist mode (#9113) #9212

merged 6 commits into from Aug 16, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9113

What problem does this PR solve?

Issue Number: close #9112

What is changed and how it works?

  • return error when get SkipAndWaitRedirect operator.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

support strict optimistic mode for incompatible DDL

@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#9113
e0b48dc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 13, 2023
Merged
@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Jun 13, 2023
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 13, 2023

/test all

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 13, 2023

/run-all-tests

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 14, 2023

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 14, 2023
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Aug 10, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Aug 10, 2023

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Aug 10, 2023
@wuhuizuo
Copy link
Contributor

/hold

make it re-queue in merge pool.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@wuhuizuo
Copy link
Contributor

/run-all-tests

@wuhuizuo
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot merged commit 28b0657 into pingcap:release-6.5 Aug 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

Assignees

@GMHDBJD GMHDBJD

Labels
approved area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ti-chi-bot @GMHDBJD @wuhuizuo @lance6716