Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): enum type default value set explicitly to avoid wrong enum value fetched by the encoder #9262

Merged
merged 7 commits into from
Jun 21, 2023
Merged

mounter(ticdc): enum type default value set explicitly to avoid wrong enum value fetched by the encoder #9262

merged 7 commits into from
Jun 21, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9259

What is changed and how it works?

  • mounter set the default value for the enum type explicitly, to make enum.Value set correctly.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2023
@3AceShowHand
Copy link
Contributor Author

/test all

@3AceShowHand
Copy link
Contributor Author

/test all

@3AceShowHand
Copy link
Contributor Author

/test verify

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

charleszheng44
charleszheng44 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@charleszheng44 charleszheng44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-20 02:04:17.602780976 +0000 UTC m=+68423.004031425: ☑️ agreed by charleszheng44.
  • 2023-06-20 03:31:24.42625288 +0000 UTC m=+73649.827503329: ☑️ agreed by CharlesCheung96.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, charleszheng44

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor Author

/merge

@charleszheng44 charleszheng44 mentioned this pull request Jun 20, 2023
Open
1 task
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-storage-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7810ad2 into pingcap:master Jun 21, 2023
15 of 16 checks passed
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.2

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.1

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-6.5

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.2: #9283.

In response to this:

/cherry-pick release-7.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Jun 21, 2023
Closed
Merged
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.1: #9284.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-6.5: #9285.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Jun 21, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-6.1: #9286.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2023
@3AceShowHand @ti-chi-bot
mounter(ticdc): enum type default value set explicitly to avoid wrong…
561a0f3 
… enum value fetched by the encoder (pingcap#9262)

close pingcap#9259
ti-chi-bot bot pushed a commit that referenced this pull request Jun 26, 2023
@ti-chi-bot
mounter(ticdc): enum type default value set explicitly to avoid wrong…
b518f05 
… enum value fetched by the encoder (#9262) (#9286)

close #9259
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@ti-chi-bot
mounter(ticdc): enum type default value set explicitly to avoid wrong…
6a82b6b 
… enum value fetched by the encoder (#9262) (#9284)

close #9259
ti-chi-bot bot pushed a commit that referenced this pull request Aug 2, 2023
@ti-chi-bot
mounter(ticdc): enum type default value set explicitly to avoid wrong…
0a98299 
… enum value fetched by the encoder (#9262) (#9285)

close #9259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleszheng44 charleszheng44 charleszheng44 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type enum default value is ignored when mount the event
5 participants
@3AceShowHand @ti-chi-bot @charleszheng44 @asddongmen @CharlesCheung96