Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter(ticdc): enum type default value set explicitly to avoid wrong enum value fetched by the encoder (#9262) #9285

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9262

What problem does this PR solve?

Issue Number: close #9259

What is changed and how it works?

  • mounter set the default value for the enum type explicitly, to make enum.Value set correctly.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 21, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 21, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 4, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Jul 4, 2023
@3AceShowHand
Copy link
Contributor

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added the approved label Aug 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 0a98299 into pingcap:release-6.5 Aug 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants