Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink (ticdc): Add retry limit for ddl sink #9385

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9272

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 13, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-13 03:23:46.653979661 +0000 UTC m=+561518.424318369: ☑️ agreed by 3AceShowHand.
  • 2023-07-13 06:36:55.144709307 +0000 UTC m=+573106.915048017: ☑️ agreed by nongfushanquan.

@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot merged commit ac813a2 into pingcap:master Jul 13, 2023
15 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9387.

hicqu pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 15, 2023
ref pingcap#9272

Signed-off-by: qupeng <qupeng@pingcap.com>
@asddongmen asddongmen deleted the add_retry_limit_for_ddl_sink branch November 7, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants