Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(cdc): fix internal retry algothrim (#9530) #9572

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 15, 2023

This cherry-pick contains #9265 #9322, #9358, #9385 and #9530.

What problem does this PR solve?

Issue Number: close #9518 , ref #9272

What is changed and how it works?

馃搸

  • Add changefeed warning and failed alert rules.
  • Change the max retry duration for changefeed errors from 90 minutes to 30 minutes.
  • Use warning state instead of error state for changefeeds. If a changefeed encounters an error, it will enter the warning state and retry for up to 30 minutes. If the retry is successful, it will resume normal operation. If not, it will become a failed state and block GC for gcttl time.
  • Allow cdc cli changefeed list to display the error message when a changefeed is in warning state.
> ./cdc cli changefeed list
[
  {
    "id": "test1",
    "namespace": "default",
    "summary": {
      "state": "warning",
      "tso": 443594678570057753,
      "checkpoint": "2023-08-16 17:50:07.387",
      "error": {
        "time": "2023-08-16T18:04:37.930002+08:00",
        "addr": "127.0.0.1:8300",
        "code": "CDC:ErrProcessorUnknown",
        "message": "SinkManagerRunError"
      }
    }
  }
]
  • Limit the sinkManager to a maximum of 30 minutes for retrying on sink errors.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Limit the sinkManager to a maximum of 30 minutes for retrying on sink errors.

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 15, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label Aug 15, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2023
@asddongmen asddongmen assigned asddongmen and unassigned hicqu Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2023
@asddongmen asddongmen force-pushed the cherry-pick-9530-to-release-6.5 branch from 53fa22b to c5377df Compare August 15, 2023 07:36
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 16, 2023
@asddongmen
Copy link
Contributor

/test all

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/hang

@asddongmen asddongmen added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@asddongmen
Copy link
Contributor

/retest

@asddongmen asddongmen removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@asddongmen
Copy link
Contributor

/retest

@hicqu
Copy link
Contributor

hicqu commented Aug 16, 2023

/lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,hicqu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asddongmen
Copy link
Contributor

/test all

@asddongmen
Copy link
Contributor

/test all

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot merged commit 425b10a into pingcap:release-6.5 Aug 16, 2023
9 of 10 checks passed
@hicqu hicqu deleted the cherry-pick-9530-to-release-6.5 branch August 17, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants