roughly cleanup data between regions gap #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Sep 11, 2017
| // we treat CF_LOCK especially. For the others column families: 1) the data set | ||
| // in these column families usually are very large, so we don't want to trigger | ||
| // seek for these column families; 2) keys in these column families have ts tail, | ||
| // so end_key never exists in these column families. | ||
| if cf == CF_LOCK { |
There was a problem hiding this comment.
I think we can ignore lock and raft and let outer clean up the region.
There was a problem hiding this comment.
This function only used in quickly cleanup data between regions gaps, there is no more
other cleanup outer.
There was a problem hiding this comment.
So when we really clean up all data for the region? Will leave some stale data?
There was a problem hiding this comment.
Yes, will leave some stale data, but if we don't have a mechanism to roughly cleanup these stale data, there is a risk that the stale data may increase to very huge.
BusyJay
reviewed
Sep 11, 2017
src/util/rocksdb/mod.rs
Outdated
| try!(db.delete_file_in_range_cf(handle, start_key, iter.key())); | ||
| iter.seek(start_key.into()); | ||
| let wb = WriteBatch::new(); | ||
| while iter.valid() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.