raftstore: add drop message metrics #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Sep 19, 2017
src/raftstore/store/store.rs
Outdated
| @@ -770,6 +770,7 @@ impl<T: Transport, C: PdClient> Store<T, C> { | |||
| fn on_raft_message(&mut self, mut msg: RaftMessage) -> Result<()> { | |||
| let region_id = msg.get_region_id(); | |||
| if !self.is_raft_msg_valid(&msg) { | |||
| self.raft_metrics.message.drop_invalid_msg += 1; | |||
There was a problem hiding this comment.
any reason to drop the message? stale, store not match or others?
I think we should more detailed metric tags.
siddontang
reviewed
Sep 20, 2017
src/raftstore/store/local_metrics.rs
Outdated
| @@ -88,6 +88,13 @@ pub struct RaftMessageMetrics { | |||
| pub heartbeat_resp: u64, | |||
| pub transfer_leader: u64, | |||
| pub timeout_now: u64, | |||
| pub drop_mismatch_store_id: u64, | |||
There was a problem hiding this comment.
I prefer using another struct for these drop messages.
siddontang
approved these changes
Sep 20, 2017
Add a new metrics for recording dropped messages
|
PTAL |
|
PTAL @javaforfun |
|
No need, here we just want to know the invalid message like stale, mismatched store ID, dropping. |
BusyJay
reviewed
Sep 22, 2017
src/raftstore/store/store.rs
Outdated
| @@ -721,6 +723,7 @@ impl<T: Transport, C: PdClient> Store<T, C> { | |||
| region_id, | |||
| p | |||
| ); | |||
| self.raft_metrics.message_dropped.destroy_stale_peer += 1; | |||
overvenus
force-pushed
the
ov/drop-raft-msg
branch
from
9a41c1d
to
60eb8e7
Compare
|
PTAL |
|
LGTM |
|
/run-all-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records dropped raft messages. Please let me know if I am missing something.