Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: customize server version #268

Merged
merged 1 commit into from
Apr 13, 2023
Merged

*: customize server version #268

merged 1 commit into from
Apr 13, 2023

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Apr 13, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #266

Problem Summary:
Support customize server version

What is changed and how it works:

  • Server version is set by HandshakeHandler
  • For the default handler, the server version is set in config
  • Rename testXXX to XXX because they are not used for testing

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
  1. Update proxy.toml
  2. Check the server version from the client

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox April 13, 2023 04:56
@xhebox xhebox merged commit 35f19b9 into pingcap:main Apr 13, 2023
@djshow832 djshow832 deleted the server_version branch April 13, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize TiDB version
2 participants
@djshow832 @xhebox