Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parition table isn't shown in show command (#1354) #1374

Merged
merged 3 commits into from
Jan 16, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 15, 2020

cherry-pick #1354 to release-2.1


What problem does this PR solve?

This PR closes #1330

What is changed and how it works?

When we process ShowCommand, we first check the emptiness of partitionSpec. We append partition info if such spec is not empty.

Check List

Tests

tests will be added later.

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Contributor

/run-all-tests

@birdstorm birdstorm merged commit 3bb3c55 into pingcap:release-2.1 Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants