Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump spark version to avoid vulnerabilities #2544

Merged
merged 9 commits into from
Sep 22, 2022
Merged

Bump spark version to avoid vulnerabilities #2544

merged 9 commits into from
Sep 22, 2022

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Sep 15, 2022 •
edited

What problem does this PR solve?

This pr is a supplement to #2486. It bumps the Spark version：

  • from 3.0.2 to 3.0.3
  • from 3.1.1 to 3.1.3
  • from 3.2.1 to 3.2.2

Note that spark 3.0.3 still has vulnerabilities

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0 shiyuhang0 changed the title bump spark version Bump spark version to avoid vulnerabilities Sep 15, 2022
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.1

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.1

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.1

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.1

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.1

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

xuanyu66
xuanyu66 requested changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@xuanyu66 xuanyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pingcap/tispark/blob/master/pom.xml#L183-L209
Bump these too

@xuanyu66
Copy link
Collaborator

And the better solution is to define variables so that we won't miss the places need to be modified

@shiyuhang0
Copy link
Member Author

https://github.com/pingcap/tispark/blob/master/pom.xml#L183-L209 Bump these too

has done in #2486

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

@zhangyangyu zhangyangyu added the needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 label Sep 22, 2022
@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

zhangyangyu
zhangyangyu reviewed Sep 22, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

2 similar comments
@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.1

@shiyuhang0
Copy link
Member Author

/run-all-tests profile=spark3.2

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 069a769

@ti-chi-bot ti-chi-bot merged commit 821abde into pingcap:master Sep 22, 2022
@ti-srebot
Copy link
Collaborator

cherry pick to release-release failed

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 22, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2555.

ti-chi-bot added a commit that referenced this pull request Sep 23, 2022
@ti-chi-bot
Bump spark version to avoid vulnerabilities (#2544) (#2555)
da155a8
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@shiyuhang0
Bump spark version to avoid vulnerabilities (pingcap#2544)
3f09979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@xuanyu66 xuanyu66 xuanyu66 approved these changes

@Daemonxiao Daemonxiao Daemonxiao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shiyuhang0 @ti-chi-bot @xuanyu66 @ti-srebot @zhangyangyu @Daemonxiao