Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cluster index scan ref:#2453 #2560

Merged
merged 15 commits into from
Oct 8, 2022
Merged

support cluster index scan ref:#2453 #2560

merged 15 commits into from
Oct 8, 2022

Conversation

qidi1
Copy link
Contributor

@qidi1 qidi1 commented Sep 26, 2022

Signed-off-by: qidi1 1083369179@qq.com

What problem does this PR solve?

What is changed and how it works?

  • Build fake index when table has common handle.
  • Use the logical of secondary index to build fake index range.
  • Add range builder ClusterIndexScanKeyRangeBuilder to build table scan range.

Check List

Tests

  • Unit test
  • Integration test

@qidi1
support cluster index scan ref:pingcap#2453
ec8b0c1 
Signed-off-by: qidi1 <1083369179@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • shiyuhang0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

qidi1 and others added 3 commits September 26, 2022 21:00
@qidi1
change function name
ade9d9b 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
change license header
434e188 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Merge branch 'master' into addClusterIndexScan
5c4578a
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 26, 2022

/run-all-tests

@qidi1
fix test error
986af65 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
format code
e2aed90 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 27, 2022

/run-all-tests

1 similar comment
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 27, 2022

/run-all-tests

@qidi1
add some comment
0887832 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
format
41c6789 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 28, 2022

/run-all-tests

@qidi1
Copy link
Contributor Author

qidi1 commented Sep 28, 2022

/run-all-tests

@qidi1
Copy link
Contributor Author

qidi1 commented Sep 28, 2022

/run-all-tests

@qidi1
change to tableID
006b004 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 28, 2022

/run-all-tests

1 similar comment
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 29, 2022

/run-all-tests

@qidi1
add test
9ea42ea 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
format code
213386a 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 29, 2022

/run-all-tests

@qidi1
do as comment
3725e60 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Sep 30, 2022

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

CI always fails with the following picture
6SqKB8zW1l

@qidi1
repaire fail test
a4d1708 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Oct 6, 2022

CI always fails with the following picture 6SqKB8zW1l

repaired

@qidi1
Copy link
Contributor Author

qidi1 commented Oct 6, 2022

/run-all-tests

2 similar comments
@qidi1
Copy link
Contributor Author

qidi1 commented Oct 6, 2022

/run-all-tests

@qidi1
Copy link
Contributor Author

qidi1 commented Oct 6, 2022

/run-all-tests

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a4d1708

@ti-chi-bot ti-chi-bot merged commit 6e1dc7a into pingcap:master Oct 8, 2022
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@qidi1
support cluster index scan ref:pingcap#2453 (pingcap#2560)
e09dab1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuanyu66 xuanyu66 xuanyu66 requested changes

@Daemonxiao Daemonxiao Daemonxiao approved these changes

@shiyuhang0 shiyuhang0 shiyuhang0 approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support all cluster index in selection query
5 participants
@qidi1 @ti-chi-bot @shiyuhang0 @xuanyu66 @Daemonxiao